Skip to content

fix(app): import instance issues - #8329

Merged
mergify[bot] merged 1 commit into
mainfrom
cal/fix-import-issues
Nov 16, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
cal/fix-import-issues

Conversation

@IMB11

@IMB11 IMB11 commented Nov 14, 2026

Copy link
Copy Markdown
Member

Closes DEV-1521

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

  • Fixes some issues with importing instances from CurseForge, Prism and MultiMC.

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Queue requested — the merge queue status continues in this comment ↓.

@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

This PR fixes several instance import problems:

  • CurseForge imports keep the loader named in the instance metadata.
  • MultiMC and Prism imports follow their configured instance folders.
  • MultiMC and Prism imports find icons by their file names.
  • Failed imports leave the destination profile in place.

No actionable issues were found. Verification was limited to reading code; no builds or tests were run.

Reviews (1) · Last reviewed commit: "fix(app): import instance issues" · Reviewed by Greptile

@mergify

mergify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Merged into main as 94c7bda at 17:47 UTC

1 min in the queue, with no time running CI.

So far

2 merge conditions met
  • github-review-approved · required by GitHub branch protection
  • any of · required by GitHub branch protection:
    • check-skipped = Lint and Test
    • check-neutral = Lint and Test
    • check-success = Lint and Test

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued label Nov 16, 2026
@mergify
mergify Bot merged commit 94c7bda into main Nov 16, 2026
9 checks passed
@mergify
mergify Bot deleted the cal/fix-import-issues branch November 16, 2026 17:47
@mergify mergify Bot removed the queued label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants