feat(hosting frontend): suspended server files download - #7422
Open
fetchfern wants to merge 6 commits into
Open
Conversation
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Contributor
Frontend previewsLast deployed commit is 052ef565f5e9345b8069f931a989144259ff95df Persistent
Latest commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Related backend additions
Archon now returns a
download_methodfor each world, which can bedirect_node_download,backuporunavailable. For now, archon doesn't use thebackupmethod but it's still implemented here for forward-compatibility.Kyros also has a two-stage full server ZIP download flow:
GET /v1/worlds/:id/files/download-full-zip/authorizewith a session token to get a one-time download token, which can be passed toGET /v1/worlds/:id/files/download-full-zip?token=<token>Changes
The new buttons use
window.location.assigninstead ofwindow.open. window open was making my browser window flash and it avoids dealing with popup blocking policies.This also changes the server card to stay visible if the world download method isn't
unavailable: it expects archon to enforce the 30-day rentention for server files rather than never showing the server for old cancelled subscriptions. This is useful since in practice we retain server files for longer.Downloading files is only available to server owners.
Fixes DEV-1400