Repository navigation
Add browser smoke tests for the page - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds browser smoke tests for the page, which until now had only the translation-key checks in
tests/test_page.py. Each page change so far was checked by hand in a browser.tests/test_browser.pyruns the realcollectin-process against the existing respx scenario with Jira, writes the site to a temp directory, serves it on a free local port, and drives it in headless Chromium throughpytest-playwright. Every test also fails on a console error or an uncaught page error.team/svc, and the issue list puts Done first (SHOP-9, then SHOP-12);for SHOP-12, writes#issues=SHOP-12&team/svc=1.2.0, and a reload keeps the pick and the tick;Состав релизаwith no{placeholder}left.pytest-playwright>=0.10joins thedevgroup, so the module imports everywhere; itsgreenletdependency has wheels for 3.14t, so the free-threaded jobs still install. The tests carry asmokemarker thataddoptsdeselects, sojust test,just test-ci, the floors and pytest matrices, and the coverage gate do not need a browser.just test-smokeinstalls Chromium when missing and runs only them, and a newsmokejob runs that on 3.13 withplaywright install --with-deps chromium. The browser download, about 100 MB, is not cached yet.Playwright for Python keeps the repo free of Node.
AGENTS.mdnow points to the smoke tests instead of saying the page has none.Locally:
just test-smokepasses (4 tests, about 3.5 s), and all four fail when a JavaScript error is injected into the page.just test-ci(140 passed, 4 deselected, 100% coverage) andjust lint-cipass.