Repository navigation
Record the state of linked merge requests and show it on the page (schema 7) - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30. Report schema 7; release as 0.9.0.
Each merge request link of a Jira issue that points into a collected service now has
state(opened,closed,locked,merged) andtarget_branch. When a row holds the merge request, it is recorded as merged into the default branch without a request. Otherwise the collector reads it, at most once per run, through the same_linked_merge_requestthat--jirauses, so a merged one is cached as a settled fact. In a--jirarun,_link_targetrecords the state of the merge requests it already reads, and the later pass reuses them, so none is read twice.The state stays
nullfor commit links, for projects outside the report, for services that failed or have CI/CD or Environments disabled (the README says those are not queried), and when GitLab cannot return the merge request. A failed read does not fail the service or the run; the page then falls back to the old wording.Closed merge requests still count as touching the service, and there is no flag: a merged one is cached, so a large group pays mainly for open ones.
On the page, an issue that links only to changes outside the range now says why:
not merged(open or locked),in prod(merged into the default branch),older than the range(the same, when the range was cut atRELEASE_SCOPE_MAX_COMMITS),merged into <branch>, orclosed.in prod or not mergedremains for commit links and unreadable merge requests. The service line lists these states even when a tag is picked for other chosen issues, so a picked tag no longer hides that a chosen issue is not merged in that service. New strings exist in English and Russian.Every earlier schema bump shipped as a new minor version with the skill's range moved, so the README's Pages example, its skill note, and
SKILL.mdnow runrelease-scope>=0.9,<0.10. The README's Report section andSKILL.mddescribe the new fields.Tests, written first and failing before the change: a link held by a row is merged into
mainwith no request; a link outside the range recordsopened,closed, merged into another branch, and merged intomain; a merged one comes from the cache on the second run; a 404 leaves the state unknown and the service intact; a--jirarun records the states of its scope links and reads each merge request once.just test-ci(140 passed, 100% coverage) andjust lint-cipass. The page has no tests; I checked it in a browser against a mock schema-7 report with each state, in English and Russian, with no console errors.