fix(bench): stabilize tied recent-post ordering - #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make recent-post result membership deterministic when multiple writes share the same millisecond timestamp.
PR #255 exposed the issue: the deterministic response-byte benchmark measured 137,029 bytes on its first CI run, then the committed 132,989-byte baseline on rerun with no code change.
Cause
SqlStore.listRecentPosts()ordered only by millisecond-resolutionupdatedAtbefore applyingLIMIT. Large fixture batches create timestamp ties across the limit boundary, leaving SQLite free to select different posts depending on version/query plan. The JSON store also relied implicitly on stable sort behavior.Fix
rowid DESCas the explicit SQLite tie-breakerNo benchmark baseline update is needed: repeated Node 22 and Node 24 runs now both produce exactly 132,989 typical bytes and 196,269 heavy bytes.
Validation
npm testnpm run coveragenpm run test:workernpm run typechecknpm run lintnpm run format:checknpm run security:auditnpm run bench:check -- --gate deterministicThis PR description was generated by Pi using gpt-5.6-sol