Skip to content

docs(docker): drop the stale --db-path comments in the fetch and git Dockerfiles - #5531

Merged
cliffhall merged 1 commit into
v2/mainfrom
v2/docs/5483-docker-stale-comments
Nov 12, 2026
Merged

cliffhall merged 1 commit into
v2/mainfrom
v2/docs/5483-docker-stale-comments

Conversation

@cliffhall

Copy link
Copy Markdown
Member

Closes #5483

Description

Both Python servers' Dockerfiles carried a comment copied from a database server's image, just above ENTRYPOINT:

# when running the container, add --db-path and a bind mount to the host's db file

Neither mcp-server-fetch nor mcp-server-git has a --db-path option.

  • src/fetch/Dockerfile: the comment is removed. Fetch is an HTTP client and needs no mount.
  • src/git/Dockerfile: the comment now says to bind-mount the host directory that holds the repositories, and to add --repository with an in-container path to confine the server to one of them, matching the README's Docker examples and its --repository guidance.

The third point in the issue, src/git/README.md saying the image runs as root, was already fixed on v2/main by #5473. The README now documents the unprivileged app user and /home/app/.gitconfig, so this PR does not change it.

Thanks to @muhammedriswanp, who reported this and prototyped the same fix on a branch in their fork.

Server Details

  • Servers: fetch, git
  • Changed: Dockerfile comments only. No tools, resources, prompts, options or image behavior change.

Motivation and Context

The stale comment tells Docker users to pass an option that does not exist. See #5483.

How Has This Been Tested?

The change has nothing a client can observe, so the evidence is a targeted probe:

  • grep -rn "db-path\|db file" src/*/Dockerfile src/*/README.md finds nothing (exit 1).
  • docker build --check src/fetch and docker build --check src/git both print Check complete, no warnings found.
  • npm run local:gate exits 0. The git comment's wording was amended once while the gate was running; that edit touches only a Dockerfile comment, which no gate stage parses.

Breaking Changes

None. Client configurations do not change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation (not applicable: no protocol surface touched)
  • My changes follow MCP security best practices
  • I have updated the server's README accordingly (not applicable: the git README was already corrected by fix(docker): run every server image as its non-root user #5473; nothing else documents the comment)
  • I have added a changeset (npm run changeset) if this changes what a TypeScript server publishes (not applicable: Python servers only)
  • I have tested this with an LLM client (not applicable: comment-only change, no client-observable surface)
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling (not applicable: no code)
  • I have documented all environment variables and configuration options (not applicable: none added)

🤖 Generated with Claude Code

…Dockerfiles

The fetch and git Dockerfiles carried a comment copied from a database
server's image, telling the user to pass --db-path and mount a db file.
Neither server has such an option. Fetch needs no mount, so its comment
goes; git's now says to bind-mount the repository and pass its path to
--repository. The git README's container-user line was already corrected
by #5473.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
@cliffhall cliffhall added the v2 label Nov 12, 2026
@cliffhall
cliffhall requested a balanced review from Copilot November 12, 2026 04:30
@changeset-bot

changeset-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fafb59a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

fetch: MCP interface diff

Base: bdfb2e314df7 (Merge pull request #5529 from modelcontextprotocol/v2/chore/5506-alerts-hoisted-copy-scope)
Head: the build in this checkout, at 38a0619daa41 (Merge fafb59a into bdfb2e3)

Diffed because it was named (--server).

✅ No interface changes detected.

Tools Prompts Resources Resource templates
Base 1 1 0 0
Head 1 1 0 0

Updated by this run for fafb59a78826b6daafc3a6f4d68545628e576b0f.

@github-actions

Copy link
Copy Markdown
Contributor

git: MCP interface diff

Base: bdfb2e314df7 (Merge pull request #5529 from modelcontextprotocol/v2/chore/5506-alerts-hoisted-copy-scope)
Head: the build in this checkout, at 38a0619daa41 (Merge fafb59a into bdfb2e3)

Diffed because it was named (--server).

✅ No interface changes detected.

Tools Prompts Resources Resource templates
Base 14 2 0 0
Head 14 2 0 0

Updated by this run for fafb59a78826b6daafc3a6f4d68545628e576b0f.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the documentation-only Dockerfile guidance updates.

No open issues 🎉

What changed in this PR

Corrects stale Dockerfile guidance for the Python Fetch and Git servers, addressing the remaining documentation fixes in #5483. Only comments change; image behavior is unchanged.

Changes:

  • Removes Fetch’s incorrect database-path and mount instructions.
  • Updates Git’s comment to describe repository bind mounts and --repository with an in-container path.
  • Leaves the Git README unchanged because #5473 already corrected its runtime-user documentation.
File Description
src/​git/​Dockerfile Replaces database guidance with repository-mount and confinement instructions.
src/​fetch/​Dockerfile Removes the stale --db-path comment.

Review effort: Balanced

@cliffhall

Copy link
Copy Markdown
Member Author

Copilot round 1: clean, no findings and no suppressed comments. The review loop stops here (clean-round exit).

@cliffhall
cliffhall merged commit a9558c5 into v2/main Nov 12, 2026
48 checks passed
@cliffhall
cliffhall deleted the v2/docs/5483-docker-stale-comments branch November 12, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(docker): correct stale --db-path comments in fetch/git Dockerfiles and clarify git README

2 participants