Repository navigation
chore(everything): exclude compiled tests and vitest config from dist - #4933
Closed
bluetomlee wants to merge 1 commit into
Closed
bluetomlee wants to merge 1 commit into
bluetomlee wants to merge 1 commit into
Conversation
The build tsconfig had no exclude, so tsc emitted __tests__/** and vitest.config into dist/ and "files": ["dist"] published them. Align the exclude with src/filesystem's tsconfig so the tarball ships only the server and its docs, like the other three TS servers. Fixes modelcontextprotocol#4930 Signed-off-by: Kevin Li <tomliyi@qq.com>
|
Member
|
Thanks, @bluetomlee but this was meant to be against v2/main with changesets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4930
Summary
src/everything/tsconfig.jsonhad noexclude, sotscemitted__tests__/**andvitest.config.jsintodist/, and"files": ["dist"]published them. This adds the same exclude listsrc/filesystem/tsconfig.jsonalready uses, so the tarball ships only the server and itsdocs/, matching the other three TS servers.Changes
src/everything/tsconfig.json— addexclude:**/__tests__/**,**/*.test.ts,**/*.spec.ts,vitest.config.ts(list taken verbatim fromsrc/filesystem/tsconfig.json).Verification (before / after)
Clean rebuild of
src/everything(npm install→npm run build), original config vs. this branch:__tests__/{prompts,registrations,resources,server,tools}.test.js+vitest.config.js)npm pack --dry-runafter the change lists onlyREADME.md, the compiled server files underdist/, anddist/docs/*— no tests, no test config.Tests are unaffected (Vitest compiles from source, not
dist/):npx vitest run→ 109 passed (5 test files), identical before and after.Checklist
src/filesystem's exclude)npm pack --dry-run