Skip to content

docs(everything): rename the phantom 'options' JSDoc param to 'constraints' - #4774

Closed
simpleqt wants to merge 1 commit into
modelcontextprotocol:mainfrom
simpleqt:docs/gzip-fetch-jsdoc
Closed

simpleqt wants to merge 1 commit into
modelcontextprotocol:mainfrom
simpleqt:docs/gzip-fetch-jsdoc

Conversation

@simpleqt

@simpleqt simpleqt commented Sep 7, 2026

Copy link
Copy Markdown

fetchSafely in src/everything/tools/gzip-file-as-resource.ts destructures its second parameter directly ({ maxBytes, timeoutMillis }), so the documented @param {Object} options identifier doesn't exist in the signature. The doc now names the destructured object constraints (matching what it carries) while keeping the property docs. Docs-only.

…aints'

fetchSafely destructures its second parameter directly ({ maxBytes,
timeoutMillis }) — no 'options' identifier exists; the doc now names the
destructured object consistently.
Copilot AI balanced review requested due to automatic review settings September 7, 2026 16:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cliffhall cliffhall added the closed-out-of-scope Closed: out of scope here; listings and new servers go to the MCP Registry (#4875) label Oct 20, 2026
@cliffhall

Copy link
Copy Markdown
Member

Thank you for this pull request, and apologies for the long wait for a response.

These servers are reference implementations: they exist to show how each part of MCP is used, not to be general-purpose products, so new features are taken selectively, and this change isn't one the maintainers plan to take. This repository also now accepts issues, not pull requests, from anyone but its maintainers; the policy is in CONTRIBUTING.md.

This is not a judgment on the idea or on you. A server in the MCP Registry may well offer it, and anyone is welcome to build on these servers to do so. If you think we've misread it, please open an issue describing the problem and the expected behavior.

This is part of the backlog triage in #4875.

@cliffhall cliffhall closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-out-of-scope Closed: out of scope here; listings and new servers go to the MCP Registry (#4875)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants