Repository navigation
Conversation
The example responses in src/time/README.md did not match what the server
actually returns:
- Both examples omitted `day_of_week`, which `TimeResult` declares and the
server always populates via `strftime("%A")`.
- The `convert_time` source showed 12:30 although the request asks for 16:30.
- The target showed `2024-01-01T12:30:00+09:00`, i.e. the conversion had no
effect. New York 16:30 EST is 06:30 the next day in Tokyo.
- `time_difference` read `+13.0h`; EST (-5) to JST (+9) is +14.0h.
- A trailing comma after `time_difference` made the JSON invalid.
Verified against src/time/src/mcp_server_time/server.py.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
cliffhall
added
the
closed-superseded-v2
|
Thank you for this pull request, and apologies for the long wait for a response. Since it was opened, the reference servers have been rebuilt for the 2026-07-28 MCP specification (#4857) and released as v2 (2.0.0 on npm for the TypeScript servers, 2026.10.19 on PyPI for the Python servers). The code this PR changes has been replaced, and the behavior it addresses has either been fixed in v2 or no longer exists in the same form. This is not a judgment on the change or on you; it's a consequence of the code it targets having been replaced. If the problem still happens on v2, please open a fresh issue with the version you're running and steps to reproduce. Note that this repository now accepts contributions as issues rather than pull requests from anyone but its maintainers; see This is part of the backlog triage in #4875. |
The "Example Interactions" responses in
src/time/README.mddon't match what the server actually returns. Verified againstsrc/time/src/mcp_server_time/server.py, whereTimeResultdeclares four fields (timezone,datetime,day_of_week,is_dst).Five issues:
day_of_week, which the server always sets viastrftime("%A").convert_timesource shows12:30though the request asks for16:30.2024-01-01T12:30:00+09:00— the conversion did nothing. New York 16:30 EST is2024-01-02T06:30:00+09:00in Tokyo.time_differencereads+13.0h; EST (-5) to JST (+9) is +14.0h.time_differencemakes the JSON invalid.Documentation only — no code changes.
Credit to @latent-9, who identified these same issues in #4597 and closed that PR themselves.