fix(time): correct invalid IANA timezone example in convert_time description#4536
Open
Lumos-789 wants to merge 1 commit into
Open
Conversation
…ription
The 'target_timezone' parameter description used 'America/San_Francisco'
as an example, which is not a valid IANA timezone identifier — the tz
database has no such key (San Francisco uses 'America/Los_Angeles').
Verification:
>>> from zoneinfo import ZoneInfo
>>> ZoneInfo('America/San_Francisco')
ZoneInfoNotFoundError: No time zone found with key America/San_Francisco
Impact:
LLM clients consuming this description as a usage hint tend to copy example
values verbatim. Passing 'America/San_Francisco' causes the server to
reject the call with INVALID_PARAMS, surprising the user.
Fix: replace with the valid 'America/Los_Angeles' identifier. This also
brings target_timezone in line with the source_timezone description,
which already correctly uses 'America/New_York' / 'Europe/London'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
convert_timetool'starget_timezoneparameter description uses'America/San_Francisco'as an example. This is not a valid IANA timezone identifier — the tz database has no such key (San Francisco uses'America/Los_Angeles').Impact
LLM clients consuming this description as a usage hint tend to copy example values verbatim. Passing
'America/San_Francisco'causes the server to reject the call withINVALID_PARAMS, surprising the user.Fix
Replace the example with the valid
'America/Los_Angeles'identifier. This also bringstarget_timezonein line with thesource_timezonedescription, which already correctly uses'America/New_York'/'Europe/London'.Verification
San_Franciscoacrosssrc/time/test/— only the production code uses it).