Skip to content

fix(filesystem): normalize paths for glob matching - #4373

Closed
go165 wants to merge 1 commit into
modelcontextprotocol:mainfrom
go165:go165/filesystem-posix-glob-paths
Closed

go165 wants to merge 1 commit into
modelcontextprotocol:mainfrom
go165:go165/filesystem-posix-glob-paths

Conversation

@go165

@go165 go165 commented Jun 14, 2026

Copy link
Copy Markdown

Summary

  • normalize filesystem search relative paths to POSIX separators before minimatch evaluation
  • keep returned search results unchanged as full filesystem paths
  • add a regression test for Windows-style relative paths matching slash-based glob patterns

Fixes #3517

Validation

  • npm exec --workspace src/filesystem -- vitest run tests/lib.test.ts --coverage=false
  • git diff --check

Blocked local checks:

  • npm test --workspace src/filesystem: the target lib suite passed, but the full package test run also invokes startup/structured-content tests that require dist/index.js and workspace SDK resolution in this fresh worktree.
  • npm run build --workspace src/filesystem: blocked in this fresh worktree because @modelcontextprotocol/sdk workspace dependencies are not installed/resolved locally. I used the existing dependency checkout only for the targeted lib test and did not reinstall the full workspace.

@cliffhall cliffhall added the closed-superseded-v2 Closed: fixed or made obsolete by the v2 / 2026-07-28 refactor (#4875) label Oct 20, 2026
@cliffhall

Copy link
Copy Markdown
Member

Thank you for this pull request, and apologies for the long wait for a response.

Since it was opened, the reference servers have been rebuilt for the 2026-07-28 MCP specification (#4857) and released as v2 (2.0.0 on npm for the TypeScript servers, 2026.10.19 on PyPI for the Python servers). The code this PR changes has been replaced, and the behavior it addresses has either been fixed in v2 or no longer exists in the same form.

This is not a judgment on the change or on you; it's a consequence of the code it targets having been replaced. If the problem still happens on v2, please open a fresh issue with the version you're running and steps to reproduce. Note that this repository now accepts contributions as issues rather than pull requests from anyone but its maintainers; see CONTRIBUTING.md.

This is part of the backlog triage in #4875.

@cliffhall cliffhall closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-superseded-v2 Closed: fixed or made obsolete by the v2 / 2026-07-28 refactor (#4875)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Filesystem server glob pattern matching inconsistent across platforms

2 participants