Repository navigation
fix(memory): honor MEMORY_FILE_PATH relative to cwd and prepare storage dir - #4327
KirtiRamchandani wants to merge 1 commit into
Conversation
…ge dir Resolve relative MEMORY_FILE_PATH against process.cwd() instead of the installed package directory, create parent directories for custom paths, and migrate legacy .json custom paths to .jsonl. Fixes modelcontextprotocol#692
cliffhall
added
the
closed-superseded-v2
|
Thank you for this pull request, and apologies for the long wait for a response. Since it was opened, the reference servers have been rebuilt for the 2026-07-28 MCP specification (#4857) and released as v2 (2.0.0 on npm for the TypeScript servers, 2026.10.19 on PyPI for the Python servers). The code this PR changes has been replaced, and the behavior it addresses has either been fixed in v2 or no longer exists in the same form. This is not a judgment on the change or on you; it's a consequence of the code it targets having been replaced. If the problem still happens on v2, please open a fresh issue with the version you're running and steps to reproduce. Note that this repository now accepts contributions as issues rather than pull requests from anyone but its maintainers; see This is part of the backlog triage in #4875. |
Problem
MEMORY_FILE_PATHwas resolved relative to the installed package directory when a relative path was provided, so MCP clients configuring a workspace-local path still wrote into the npx cache directory (#692).Custom absolute paths also failed when parent directories did not exist yet.
Root cause
import.meta.urlinstead ofprocess.cwd().jsonpaths were not migrated to JSONL like the default pathFix
MEMORY_FILE_PATHwithpath.resolve(process.cwd(), ...)mkdirparent directories for custom storage pathsmemory.jsontomemory.jsonlFixes #692