Skip to content

docs(time): remove trailing comma in convert_time example response - #4142

Closed
abhicris wants to merge 1 commit into
modelcontextprotocol:mainfrom
abhicris:fix/time-readme-trailing-comma
Closed

abhicris wants to merge 1 commit into
modelcontextprotocol:mainfrom
abhicris:fix/time-readme-trailing-comma

Conversation

@abhicris

Copy link
Copy Markdown

The example response object for the convert_time tool in src/time/README.md had a trailing comma after the last key ("time_difference").

  "time_difference": "+13.0h",
}

Trailing commas are not valid in standard JSON (RFC 8259 §2), so anyone copy-pasting the example into a strict JSON parser (e.g. json.loads in Python, JSON.parse in JS, a test fixture, or a schema validator) hits a parse error on what is documented as a valid response.

Why

Looking at the git history, the trailing comma was left over when a now-removed "date_changed": true field was deleted from the example. The comma after the preceding time_difference key was never cleaned up.

This makes the README example self-consistent with how the server actually serializes responses (via pydantic/json.dumps, which never emit trailing commas).

Scope

  • Docs-only, no code touched
  • 1-line change in src/time/README.md
  • No new dependencies, no breaking changes
  • Verified the block now parses with json.loads

Types of changes

  • Documentation update

Part of open-source blockchain work from kcolbchain.com - maintained by Abhishek Krishna.

The example response object for the convert_time tool in src/time/README.md
had a trailing comma after the last key ("time_difference"). Trailing
commas are not valid in standard JSON, so anyone copy-pasting the example
into a strict JSON parser (or using it in a test fixture) hits a parse
error.

The trailing comma was left over when a now-removed 'date_changed' field
was deleted from the example; the comma after the preceding key was never
cleaned up.

This is a docs-only, 1-line change.
@cliffhall cliffhall added the closed-superseded-v2 Closed: fixed or made obsolete by the v2 / 2026-07-28 refactor (#4875) label Oct 20, 2026
@cliffhall

Copy link
Copy Markdown
Member

Thank you for this pull request, and apologies for the long wait for a response.

Since it was opened, the reference servers have been rebuilt for the 2026-07-28 MCP specification (#4857) and released as v2 (2.0.0 on npm for the TypeScript servers, 2026.10.19 on PyPI for the Python servers). The code this PR changes has been replaced, and the behavior it addresses has either been fixed in v2 or no longer exists in the same form.

This is not a judgment on the change or on you; it's a consequence of the code it targets having been replaced. If the problem still happens on v2, please open a fresh issue with the version you're running and steps to reproduce. Note that this repository now accepts contributions as issues rather than pull requests from anyone but its maintainers; see CONTRIBUTING.md.

This is part of the backlog triage in #4875.

@cliffhall cliffhall closed this Oct 20, 2026
@abhicris

Copy link
Copy Markdown
Author

Thanks for the context and for taking the time to review this in the human agentic world. I understand the example belonged to the superseded server version. I’ll leave the PR closed and report it as a current-version issue only if I can reproduce it on v2. Appreciate the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-superseded-v2 Closed: fixed or made obsolete by the v2 / 2026-07-28 refactor (#4875)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants