Repository navigation
Conversation
The example response object for the convert_time tool in src/time/README.md
had a trailing comma after the last key ("time_difference"). Trailing
commas are not valid in standard JSON, so anyone copy-pasting the example
into a strict JSON parser (or using it in a test fixture) hits a parse
error.
The trailing comma was left over when a now-removed 'date_changed' field
was deleted from the example; the comma after the preceding key was never
cleaned up.
This is a docs-only, 1-line change.
|
Thank you for this pull request, and apologies for the long wait for a response. Since it was opened, the reference servers have been rebuilt for the 2026-07-28 MCP specification (#4857) and released as v2 (2.0.0 on npm for the TypeScript servers, 2026.10.19 on PyPI for the Python servers). The code this PR changes has been replaced, and the behavior it addresses has either been fixed in v2 or no longer exists in the same form. This is not a judgment on the change or on you; it's a consequence of the code it targets having been replaced. If the problem still happens on v2, please open a fresh issue with the version you're running and steps to reproduce. Note that this repository now accepts contributions as issues rather than pull requests from anyone but its maintainers; see This is part of the backlog triage in #4875. |
|
Thanks for the context and for taking the time to review this in the human agentic world. I understand the example belonged to the superseded server version. I’ll leave the PR closed and report it as a current-version issue only if I can reproduce it on v2. Appreciate the clarification. |
The example response object for the
convert_timetool insrc/time/README.mdhad a trailing comma after the last key ("time_difference").Trailing commas are not valid in standard JSON (RFC 8259 §2), so anyone copy-pasting the example into a strict JSON parser (e.g.
json.loadsin Python,JSON.parsein JS, a test fixture, or a schema validator) hits a parse error on what is documented as a valid response.Why
Looking at the git history, the trailing comma was left over when a now-removed
"date_changed": truefield was deleted from the example. The comma after the precedingtime_differencekey was never cleaned up.This makes the README example self-consistent with how the server actually serializes responses (via
pydantic/json.dumps, which never emit trailing commas).Scope
src/time/README.mdjson.loadsTypes of changes
Part of open-source blockchain work from kcolbchain.com - maintained by Abhishek Krishna.