Skip to content

fix: gate client handler bounds for local - #1068

Merged
DaleSeo merged 1 commit into
mainfrom
fix/local-client-handler-bounds
Jul 28, 2026
Merged

fix: gate client handler bounds for local#1068
DaleSeo merged 1 commit into
mainfrom
fix/local-client-handler-bounds

Conversation

@DaleSeo

@DaleSeo DaleSeo commented Jul 28, 2026

Copy link
Copy Markdown
Member

Fixes #1062.

Motivation and Context

This gives ClientHandler feature-gated trait bounds, allowing handlers with single-threaded state when the local feature is enabled while retaining the existing Send + Sync signature otherwise. It also adds a compile-time regression test using Rc.

How Has This Been Tested?

Added a regression test

Breaking Changes

None. Builds without local retain the existing Send + Sync requirements.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@github-actions github-actions Bot added T-dependencies Dependencies related changes T-test Testing related changes T-config Configuration file changes T-core Core library changes T-handler Handler implementation changes labels Jul 28, 2026
@DaleSeo
DaleSeo force-pushed the fix/local-client-handler-bounds branch from cfa1147 to bf16e06 Compare July 28, 2026 14:12
@DaleSeo
DaleSeo marked this pull request as ready for review July 28, 2026 14:13
@DaleSeo
DaleSeo requested a review from a team as a code owner July 28, 2026 14:13
@DaleSeo DaleSeo self-assigned this Jul 28, 2026
@DaleSeo
DaleSeo merged commit e5403cf into main Jul 28, 2026
22 checks passed
@DaleSeo
DaleSeo deleted the fix/local-client-handler-bounds branch July 28, 2026 15:02
@gold-silver-copper

Copy link
Copy Markdown

awesome thx for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-config Configuration file changes T-core Core library changes T-dependencies Dependencies related changes T-handler Handler implementation changes T-test Testing related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientHandler's Send + Sync bound is not gated by the local feature (unlike ServerHandler and Service)

3 participants