Repository navigation
ci: cross-compile all six binaries in one ubuntu job with CGO_ENABLED=0 - #495
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughThe workflow replaces separate macOS, Linux, and Windows build jobs with one Ubuntu job. It cross-compiles binaries for Darwin, Linux, and Windows on arm64 and amd64, uploads platform artifacts, and updates the build dependencies for e2e testing and publishing. ChangesCross-platform build workflow
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The unified build completed successfully with time to spare. No identified issue prevents merging after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
build_on_macos,build_on_linuxandbuild_on_windowswith a singlebuildjob onubuntu-latestthat cross-compiles all six binaries (darwin, linux, windows × arm64, amd64).CGO_ENABLED=0, matching theMakefile. Previously only the linux builds set it. The repo has no cgo code, so nothing needs the target OS toolchain.macos-build,linux-build,windows-build) and file names are unchanged, soe2e_testandpublishonly change theirneeds:.goimports/golangci-lintinstalls from the old build jobs.retention-days: 1like the others.The iOS agent dylib is still built on
macos-latest(build_ios_agents).Test plan
CGO_ENABLED=0(from macOS)buildjob passes on ubuntue2e_testpasses on the self-hosted Mac, which runs the ubuntu-builtmobilecli-darwin-arm64Summary by CodeRabbit