Repository navigation
Fixed Linux build error using GCC 16. - #11
Merged
Merged
Conversation
mo0kid
approved these changes
Oct 7, 2026
mo0kid
left a comment
mo0kid
left a comment
Owner
There was a problem hiding this comment.
Reviewed commit 4775bec. No blocking issues found.
Reproduced the original Musashi duplicate thread-local definition error with GCC 16.2 on macOS. With this patch, the Musashi code builds with both GCC 16.2 and Apple Clang, and the existing M68000ThreadTests pass with both compilers, including concurrent instance isolation and address-error handling.
Enabling position-independent code for WaveCore and WaveM68k is appropriate for linking these static libraries into shared plugins. Full Linux and Windows plugin builds remain unverified. The reported plugin hangs are outside the scope of this build fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a build error on Linux systems using GCC 16. I can not test these changes on macOS or Windows platforms so this need to be tested.
The VST3 plugin loads in Ardour and Bitwig but is in an unusable state. It hangs after some key presses and has lot of more issues. Ardour becomes very unresponsive too when the plugin is loaded. But this change was not intended to fix the emulator or the plugin itself in any way, it was for making it build without any errors on Linux/GCC16 platforms.