Fix find_bad_channels_maxwell cHPI correction - #14142
Draft
christianbrodbeck wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
In
find_bad_channels_maxwell,_run_maxwell_filteris called for successive data chunks, but always with the same_MoveCompinstance (mc). Inside_run_maxwell_filter,mc.initialize(...)sets up movement compensation starting at the beginning of the whole recording, rather than starting at the beginning of the relevant data chunk. This PR adds an argument to_run_maxwell_filterto use the appropriate data chunk index in the head movement recording.Additional information
Claude Opus 5 identified the issue and assisted in implementing a fix and test.