ENH: Allow control of volume interp#13966
Open
larsoner wants to merge 3 commits into
Open
Conversation
larsoner
requested review from
agramfort,
drammock and
wmvanvliet
as code owners
Member
Author
|
A couple of rendered examples:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we only allow linear interpolation of volumes during visualization. This adds nearest-neighbor support.
Also fixes a minor (mostly visual) bug with alignment when resampling to a higher-res volume, which I noticed because
resolution=None(native) should look identical toresolution=1.(upsample to 1mm) when using nearest-neighbor interp. They don't look the same onmainbut they do here. We could in principle try to do some image-based testing but it would be slow and likely fragile.There are some annoying gymnastics around
originand how to use it, but I checked visually that everything lines up properly. I also intentionally left in some debugging code (with comments) for the next time we have to sort out this sort of thing.