ENH: Make number of ICA components plotted in reports dynamic#13958
Open
athishdresu wants to merge 9 commits into
Open
ENH: Make number of ICA components plotted in reports dynamic#13958athishdresu wants to merge 9 commits into
athishdresu wants to merge 9 commits into
Conversation
athishdresu
requested review from
agramfort,
drammock and
larsoner
as code owners
athishdresu
force-pushed
the
ica-report-fix
branch
from
352cd1f to
35cce40
Compare
for more information, see https://pre-commit.ci
…ython into ica-report-fix
athishdresu
force-pushed
the
ica-report-fix
branch
from
e0c668b to
89a9ba6
Compare
Contributor
Author
|
I have updated the docstrings in mne/viz/ica.py, mne/preprocessing/ica.py, and mne/report/report.py to include the new n_channels parameter and resolve the Sphinx build warnings. Let me know if anything else is needed |
larsoner
reviewed
Jun 15, 2026
| inst : instance of Raw, Epochs or Evoked | ||
| The object to plot the sources from. | ||
| %(picks_ica)s | ||
| : int | None |
| %(picks_ica)s This only affects the behavior of the component | ||
| topography and properties plots. | ||
| n_channels : int | None | ||
| The number of ICA components to plot. If None, defaults to 20. |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
for more information, see https://pre-commit.ci
Contributor
Author
|
I've pushed the requested changes. |
larsoner
reviewed
Jun 16, 2026
| ch_order=ch_order, | ||
| picks=picks, | ||
| n_channels=n_channels, | ||
| n_components=n_components, |
Member
There was a problem hiding this comment.
Looks like this is where you have to keep it the same based on CIs
Suggested change
| n_components=n_components, | |
| n_channels=n_components, |
Can you make the change, make sure the tests pass locally, then push?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #13889 by removing the hard-coded limit of 20 components in
_plot_sourcesand allowing the user to dynamically specify the number of ICA components to plot via a newn_channelsparameter.Changes made:
n_channelsparameter toplot_ica_sources,_plot_sources, and theadd_icareport generation methods.report.pyto propagate this parameter through the report generation pipeline._plot_sourcesto default to 20 ifn_channelsis not specified, ensuring backward compatibility.Fixes #13889