Update for LXR-related API changes - #161
Merged
Merged
Conversation
wks
marked this pull request as ready for review
August 18, 2026 09:05
Collaborator
|
We see some failed tests that output all-zero characters. They seem to be an existing bug related to IO and object movement, but does not seem to be related to the LXR. None of the plans supported by the CRuby binding uses the newly introduced |
wks
approved these changes
Aug 19, 2026
wks
left a comment
wks
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The failing test doesn't seem to be caused by this PR.
oscardssmith
pushed a commit
to oscardssmith/mmtk-core
that referenced
this pull request
Aug 19, 2026
This pull request introduces a simplified version of the LXR collector. There are many features not included in this version of LXR, such as reference processing, and they will be ported to the master branch in the future. In addition to the LXR plan, this PR also makes the following changes to mmtk-core - **Field unlog bits** metadata and **field-logging barrier**. They can be used by generational and concurrent Immix plans to implement remembered set and SATB. - **`Pause::RefCount`**: a new pause kind for reference counting. - **`RootsWorkFactory::create_process_roots_work_with_root_kind`**: an experimental API with `RootKind`. - **Renamed pause-start and pause-end hooks** to merge the two mechanisms from the master branch and the LXR branch to make the names consistent. - **`UnstraddlableRegion`** to prevent the invocation of `region.contains` on regions which objects can straddle, specifically `Line`. - **Many changes to the `ImmixSpace` and `LargeObjectSpace`** to support reference counting-based Immix plans. - **Additional object metadata** to support LXR. - **Additional scheduler stages** to support LXR. - Merged the implementations of `ObjectReference::iterate_fields`. - The definition of "chunk index" is changed. - Map32: 0 is now a valid entry of the linked list, and invalid entries are represented as -1. Related PRs: - mmtk-openjdk JDK-21: mmtk/mmtk-openjdk#358 - mmtk-jikesrvm: mmtk/mmtk-jikesrvm#195 - mmtk-ruby: mmtk/mmtk-ruby#161 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Yi Lin <qinsoon@gmail.com> Co-authored-by: Kunshan Wang <wks1986@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.