Repository navigation
fix!: search for include files from archive root - #28
Open
benniekiss wants to merge 1 commit into
Open
benniekiss wants to merge 1 commit into
benniekiss wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
rockspec.namefrom theincludefiles search path when copying files.Currently, the
includessearch assumes that paths are contained under a folder in the archive root named after the module. This means that for an include declared as a path mapping,include = { "foo/bar/buz.lua" = "buz.lua" }, it actually looks for the file at{module_name}/foo/bar/buz.luaWith the patch, includes are now searched under the archive root, as declared in the mapping.
I found this issue when debugging benniekiss/rs-mod-lua#163
This is probably a breaking change.