π‘οΈ Sentinel: [CRITICAL] Fix path traversal bypass in Lua IO sandbox#19
π‘οΈ Sentinel: [CRITICAL] Fix path traversal bypass in Lua IO sandbox#19mleem97 wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: A path traversal vulnerability existed in
GregIoLuaModule.cs. The methodResolveSafeusedString.StartsWithfor sandbox validation without ensuring that the base directory path ended with a trailing directory separator. This meant a script could access files in a sibling directory that shared the same prefix (e.g., escaping/base/datato/base/data-secret).π― Impact: A malicious Lua script could bypass the intended
data/directory sandbox and read, write, or delete files in any directory on the system that happened to share the same prefix as the sandbox directory.π§ Fix: Modified
ResolveSafeto check ifdataDirFullends withPath.DirectorySeparatorCharand appends it if missing before performing theString.StartsWithvalidation. Added security comment. Documented learning in.jules/sentinel.md.β Verification: Code successfully builds with
dotnet build gregCore.csproj -c Release. TheString.StartsWithnow correctly requires an exact directory prefix match.PR created automatically by Jules for task 16477227137499691930 started by @mleem97