Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal bypass in Lua IO sandbox#19

Open
mleem97 wants to merge 1 commit into
mainfrom
sentinel/fix-lua-io-path-traversal-16477227137499691930
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal bypass in Lua IO sandbox#19
mleem97 wants to merge 1 commit into
mainfrom
sentinel/fix-lua-io-path-traversal-16477227137499691930

Conversation

@mleem97

@mleem97 mleem97 commented May 3, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: A path traversal vulnerability existed in GregIoLuaModule.cs. The method ResolveSafe used String.StartsWith for sandbox validation without ensuring that the base directory path ended with a trailing directory separator. This meant a script could access files in a sibling directory that shared the same prefix (e.g., escaping /base/data to /base/data-secret).
🎯 Impact: A malicious Lua script could bypass the intended data/ directory sandbox and read, write, or delete files in any directory on the system that happened to share the same prefix as the sandbox directory.
πŸ”§ Fix: Modified ResolveSafe to check if dataDirFull ends with Path.DirectorySeparatorChar and appends it if missing before performing the String.StartsWith validation. Added security comment. Documented learning in .jules/sentinel.md.
βœ… Verification: Code successfully builds with dotnet build gregCore.csproj -c Release. The String.StartsWith now correctly requires an exact directory prefix match.


PR created automatically by Jules for task 16477227137499691930 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant