Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal bypass in Lua IO module#18

Open
mleem97 wants to merge 1 commit into
mainfrom
fix/lua-path-traversal-bypass-7332935971261093362
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal bypass in Lua IO module#18
mleem97 wants to merge 1 commit into
mainfrom
fix/lua-path-traversal-bypass-7332935971261093362

Conversation

@mleem97

@mleem97 mleem97 commented May 2, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: A prefix-matching path traversal bypass existed in GregIoLuaModule.cs. The module used String.StartsWith to ensure the resolved path started with the sandbox base directory. However, because the base directory string did not strictly end in a directory separator, a requested path like /base/data-secret would successfully evaluate as StartsWith("/base/data") allowing arbitrary read/write access to matching folders outside the intended sandbox.
🎯 Impact: Malicious Lua scripts could potentially escape the intended sandbox (/modDir/data/) and read, write, or delete files in adjacent directories that share the same string prefix, potentially compromising mod or game data.
πŸ”§ Fix: Appended Path.DirectorySeparatorChar to dataDirFull if it doesn't already have a trailing separator before performing the StartsWith check. Documented the pattern in .jules/sentinel.md.
βœ… Verification: Compiled the solution successfully (dotnet build gregCore.csproj -c Release) to ensure no regressions and verified logic locally.


PR created automatically by Jules for task 7332935971261093362 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant