⚡ Bolt: [Performance optimization] Use O(1) device count lookup for racks in API module#158
⚡ Bolt: [Performance optimization] Use O(1) device count lookup for racks in API module#158mleem97 wants to merge 1 commit into
Conversation
…acks in API module
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced expensive
UnityEngine.Object.FindObjectsOfType<global::Il2Cpp.Rack>()withglobal::Il2Cpp.NetworkMap.instance.GetNumberOfDevices()inGregFacilityModule.GetRackCount().🎯 Why:
FindObjectsOfTypeis O(N) over all loaded objects and blocks the main thread, wasting CPU cycles when polled frequently.📊 Impact: Substantially reduces CPU usage when mods query the rack count, scaling to large environments efficiently.
🔬 Measurement: Observe reduction in CPU hitches when API consumers poll for facility metrics.
PR created automatically by Jules for task 641346162784023045 started by @mleem97