Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix prefix-matching path traversal bypass in Lua IO#157

Open
mleem97 wants to merge 1 commit into
mainfrom
sentinel/fix-lua-io-path-traversal-5407275354046974236
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix prefix-matching path traversal bypass in Lua IO#157
mleem97 wants to merge 1 commit into
mainfrom
sentinel/fix-lua-io-path-traversal-5407275354046974236

Conversation

@mleem97

@mleem97 mleem97 commented Jul 3, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The ResolveSafe function in GregIoLuaModule.cs used StartsWith on directory paths without ensuring a trailing slash. This allowed a Lua mod with a data directory mod/data to access sibling directories like mod/data_secret because "mod/data_secret".StartsWith("mod/data") evaluates to true.
🎯 Impact: Malicious Lua mods could break out of their sandboxed data directory and read/write files in sibling directories, potentially exposing sensitive data or other mods' private states.
πŸ”§ Fix: Appended a directory separator to the base path before the StartsWith check, and added an exact match check for the base directory itself. Also documented the prefix-matching bypass in .jules/sentinel.md.
βœ… Verification: Ran dotnet test tests/gregCore.Tests.csproj and manually verified path parsing logic during patching.


PR created automatically by Jules for task 5407275354046974236 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant