π‘οΈ Sentinel: [CRITICAL] Fix prefix-matching path traversal bypass in Lua IO#157
π‘οΈ Sentinel: [CRITICAL] Fix prefix-matching path traversal bypass in Lua IO#157mleem97 wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The
ResolveSafefunction inGregIoLuaModule.csusedStartsWithon directory paths without ensuring a trailing slash. This allowed a Lua mod with a data directorymod/datato access sibling directories likemod/data_secretbecause"mod/data_secret".StartsWith("mod/data")evaluates to true.π― Impact: Malicious Lua mods could break out of their sandboxed data directory and read/write files in sibling directories, potentially exposing sensitive data or other mods' private states.
π§ Fix: Appended a directory separator to the base path before the
StartsWithcheck, and added an exact match check for the base directory itself. Also documented the prefix-matching bypass in.jules/sentinel.md.β Verification: Ran
dotnet test tests/gregCore.Tests.csprojand manually verified path parsing logic during patching.PR created automatically by Jules for task 5407275354046974236 started by @mleem97