Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal prefix bypass in IO sandbox#156

Open
mleem97 wants to merge 1 commit into
mainfrom
sentinel-fix-path-traversal-prefix-13127323289353621285
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal prefix bypass in IO sandbox#156
mleem97 wants to merge 1 commit into
mainfrom
sentinel-fix-path-traversal-prefix-13127323289353621285

Conversation

@mleem97

@mleem97 mleem97 commented Jul 3, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Path traversal prefix bypass in GregIoLuaModule.cs ResolveSafe due to String.StartsWith check without a trailing slash. E.g. /mods/modA_secret bypasses a check for /mods/modA.
🎯 Impact: Arbitrary file read/write inside other directories that start with the same prefix.
πŸ”§ Fix: Append Path.DirectorySeparatorChar to dataDirFull before StartsWith check, and allow exact matching to dataDirFull.
βœ… Verification: Ran dotnet test tests/gregCore.Tests.csproj --filter "FullyQualifiedName!~CablePatchTests".


PR created automatically by Jules for task 13127323289353621285 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant