π‘οΈ Sentinel: [CRITICAL] Fix path traversal prefix bypass in IO sandbox#156
π‘οΈ Sentinel: [CRITICAL] Fix path traversal prefix bypass in IO sandbox#156mleem97 wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Path traversal prefix bypass in
GregIoLuaModule.csResolveSafedue toString.StartsWithcheck without a trailing slash. E.g./mods/modA_secretbypasses a check for/mods/modA.π― Impact: Arbitrary file read/write inside other directories that start with the same prefix.
π§ Fix: Append
Path.DirectorySeparatorChartodataDirFullbeforeStartsWithcheck, and allow exact matching todataDirFull.β Verification: Ran
dotnet test tests/gregCore.Tests.csproj --filter "FullyQualifiedName!~CablePatchTests".PR created automatically by Jules for task 13127323289353621285 started by @mleem97