⚡ Bolt: [performance improvement] Optimize GetRackCount to O(1) in GregFacilityModule#155
⚡ Bolt: [performance improvement] Optimize GetRackCount to O(1) in GregFacilityModule#155mleem97 wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
FindObjectsOfType<Il2Cpp.Rack>().Lengthwith the O(1)NetworkMap.instance.GetNumberOfDevices()[2]inGregFacilityModule.GetRackCount().🎯 Why:
FindObjectsOfTypescans the entire object hierarchy, causing high CPU load and UI hitches when used frequently or on late game saves with many objects.📊 Impact: Transforms an
O(n)hierarchy scan to anO(1)array index lookup, drastically improving execution speed for this API call.🔬 Measurement: Observe CPU load reduction during periods where
GetRackCount()is called in the game loop. Validated by ensuring unit tests continue to pass.PR created automatically by Jules for task 8847535518358910508 started by @mleem97