⚡ Bolt: Optimize GregAPI.GetRackCount by using NetworkMap.GetNumberOfDevices()#154
⚡ Bolt: Optimize GregAPI.GetRackCount by using NetworkMap.GetNumberOfDevices()#154mleem97 wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced the expensive O(N)
UnityEngine.Object.FindObjectsOfType<Il2Cpp.Rack>()call inGregAPI.GetRackCount()with O(1) lookup usingIl2Cpp.NetworkMap.instance.GetNumberOfDevices()[2]. Included a fallback for safety during uninitialized states.🎯 Why:
FindObjectsOfTypesearches the entire Unity hierarchy and creates GC allocations which degrades performance when frequently polled, especially with many devices.📊 Impact: Expected to reduce CPU time and garbage collection hitches when the API is polled for rack counts.
🔬 Measurement: Verify via in-game performance profiler that polling rack counts uses negligible CPU time compared to before.
PR created automatically by Jules for task 6848807328765113267 started by @mleem97