π‘οΈ Sentinel: [HIGH] Fix path traversal boundary check bypass in Lua IO module#153
π‘οΈ Sentinel: [HIGH] Fix path traversal boundary check bypass in Lua IO module#153mleem97 wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: The
ResolveSafefunction inGregIoLuaModule.csattempted to sandbox file access to the mod'sdatadirectory usingfullPath.StartsWith(dataDirFull). Because it did not ensuredataDirFullended with a directory separator, an attacker could access a directory outside the sandbox if its name began with the sandbox's directory name (e.g., breaking out of/mods/modA/databy targeting/mods/modA/data_secret/file.txt).π― Impact: Malicious Lua mods could exploit this boundary check bypass to read, write, or delete sensitive files residing in maliciously similarly named directories outside their intended sandbox, leading to potential unauthorized data access or corruption.
π§ Fix: Updated the
StartsWithboundary check to appendPath.DirectorySeparatorCharto the sandbox directory path before validation, while also permitting an exact string match in case the mod legitimately references the base directory itself.β Verification: The codebase has been locally patched, verified via manual inspection, and the core test suite has been successfully re-run.
PR created automatically by Jules for task 2063171553300936068 started by @mleem97