Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions codecarbon/emissions_tracker.py
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ def _initialize_runtime_state(self) -> None:
self._tasks: Dict[str, Task] = {}
self._active_task: Optional[str] = None
self._active_task_emissions_at_start: Optional[EmissionsData] = None
self._scheduler_paused_by_task = False
self._hardware = []
self._hardware_initialized = False

Expand Down Expand Up @@ -752,6 +753,10 @@ def start_task(self, task_name=None) -> None:

# Stop scheduler as we do not want it to interfere with the task measurement
if self._scheduler:
# Only resume it in stop_task if it was actually running, i.e. the tracker
# was started with start(). Pure start_task/stop_task usage must not leave
# a periodic measurement running behind.
self._scheduler_paused_by_task = not self._scheduler._stopped
self._scheduler.stop()

# Task background thread for measuring power
Expand Down Expand Up @@ -848,6 +853,10 @@ def stop_task(self, task_name: str = None) -> EmissionsData:
self._active_task = None
self._active_task_emissions_at_start = None # Clear task-specific start data

if self._scheduler is not None and self._scheduler_paused_by_task:
self._scheduler_paused_by_task = False
self._scheduler.start()

return task_emission_data

@suppress(Exception)
Expand Down
26 changes: 26 additions & 0 deletions tests/test_emissions_tracker.py
Original file line number Diff line number Diff line change
Expand Up @@ -765,6 +765,32 @@ def test_start_task_returns_when_engine_initialization_fails(
any("Tracker not initialized" in message for message in logs.output)
)

def test_stop_task_resumes_scheduler_only_if_start_task_paused_it(
self,
mock_cli_setup,
mock_log_values,
mocked_get_gpu_details,
mocked_env_cloud_details,
mocked_get_gpu_utilization_list,
mocked_is_gpu_details_available,
mocked_is_nvidia_system,
):
# Pure start_task/stop_task usage: no periodic scheduler must be left running.
tracker = EmissionsTracker(save_to_file=False)
tracker.start_task("task-only")
tracker.stop_task()
self.assertTrue(tracker._scheduler._stopped)
tracker.stop()

# start() then start_task/stop_task: the paused scheduler must be resumed.
tracker = EmissionsTracker(save_to_file=False)
tracker.start()
tracker.start_task("task-in-run")
self.assertTrue(tracker._scheduler._stopped)
tracker.stop_task()
self.assertFalse(tracker._scheduler._stopped)
tracker.stop()

@mock.patch("codecarbon.external.ram.RAM.measure_power_and_energy")
@mock.patch("codecarbon.external.hardware.CPU.measure_power_and_energy")
@mock.patch(
Expand Down
Loading