fix: skip uncorrectable RAPL counter wraps - #1321
Open
davidberenstein1957 wants to merge 2 commits into
Open
Conversation
When max_energy_range_uj is unreadable, max_energy_reading is 0, so the wrap-around branch still ran but corrected nothing, emitting a large negative energy delta straight into the CPU and total energy. Drop the sample instead, matching the EMI backend's behaviour. The same guard also covers driver resets and the transient read-error fallback. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1321 +/- ##
==========================================
+ Coverage 91.39% 91.61% +0.22%
==========================================
Files 49 49
Lines 5056 5071 +15
==========================================
+ Hits 4621 4646 +25
+ Misses 435 425 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A failed read returned Energy(0), which looked like a wrap-around and, with a readable max_energy_range_uj, injected a spurious positive delta of up to one counter range. _get_value now returns None and the sample is skipped and re-baselined. The uncorrectable-wrap warning is emitted once per file instead of every measurement cycle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
davidberenstein1957
marked this pull request as ready for review
August 12, 2026 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1309
What changed
RAPLFile.delta()now re-checks the wrap correction: if the corrected reading is still below the previous one, the sample is dropped (zero energy delta, zero power) with a warning, instead of emitting a negative energy delta.Why
max_energy_range_ujis set to0whenever it cannot be read (codecarbon/core/rapl.py:45). The comment claims wrap detection is then disabled, but only the correction was disabled — the wrap branch still ran and producedenergy_delta = energy - last_energy, a large negative value (up to -1.19e-3 kWh for a 2^32 uJ package domain). That flows unchecked into_total_energy/_total_cpu_energy, and theabs()inPower.from_energies_and_delaymasks it in the power column.The same guard also covers the other sources of a backwards counter: driver resets, suspend/resume, and the
_get_value()transient-error fallback that returns0. It mirrors whatcodecarbon/core/windows_emi.py:566-574already does for EMI.Dropping a sample loses at most one interval of genuine energy — strictly better than subtracting an hour's worth. Systems where
max_energy_range_ujis readable are unaffected.Verification
tests/test_rapl_permissions.py:test_rapl_wraparound_without_max_skips_sample— fails on master (energy_delta.kWhis about -1.11e-3), passes here.test_rapl_wraparound_with_max_is_corrected— pins the existing wrap correction against regression.uv run pytest tests/test_rapl_permissions.py -q→ 2 passed, 2 skipped (the pre-existing Linux-only cases).black --checkclean;ruffreports only pre-existing findings in the touched files.Merge order
This should land before the
rapl_include_dramchange: DRAM domains have smaller max ranges and wrap far more often, which makes this defect fire much more frequently.🤖 Generated with Claude Code