Add a "diff" view to the release tracks - #905
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## beta #905 +/- ##
==========================================
- Coverage 40.66% 40.22% -0.45%
==========================================
Files 199 199
Lines 25471 25763 +292
Branches 1278 1310 +32
==========================================
+ Hits 10359 10363 +4
- Misses 15067 15355 +288
Partials 45 45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| const baselineEntry = stagedEntry ?? memberEntry; | ||
|
|
||
| return forkJoin({ | ||
| current: this.fetchObjectVersion(item.object_ref), |
There was a problem hiding this comment.
Should this fetch use item.object_modified here? Without it, candidate diffs compare always against the latest object, which could potentially drift from the version pinned to the release track (e.g. if the member sync strategy doesn't track the latest object)
| const relationshipAddedAfter = | ||
| tier === 'candidate' | ||
| ? this.findStagedEntry(item.object_ref)?.object_modified | ||
| : undefined; |
There was a problem hiding this comment.
I think this should also check from the member entry when there isn't a staged entry, otherwise the candidate vs. member diffs won't mark relationships as added since the member version
Add a diff view to the release tracks to be able to distinguish between candidates, staged and members