Skip to content

Add a "diff" view to the release tracks - #905

Open
adpare wants to merge 17 commits into
betafrom
release-diff-old
Open

Add a "diff" view to the release tracks#905
adpare wants to merge 17 commits into
betafrom
release-diff-old

Conversation

@adpare

@adpare adpare commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Add a diff view to the release tracks to be able to distinguish between candidates, staged and members

@adpare
adpare requested a review from clemiller July 29, 2026 04:19
@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 20.53571% with 267 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.22%. Comparing base (aca11cc) to head (a982ebb).

Files with missing lines Patch % Lines
...release-track-page/release-track-page.component.ts 17.91% 197 Missing ⚠️
...p/components/stix/stix-list/stix-list.component.ts 30.90% 38 Missing ⚠️
src/app/classes/stix/relationship.ts 11.76% 15 Missing ⚠️
...pp/views/stix/stix-dialog/stix-dialog.component.ts 29.41% 12 Missing ⚠️
...x/relationship-view/relationship-view.component.ts 0.00% 3 Missing ⚠️
src/app/views/stix/stix-view-page.ts 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #905      +/-   ##
==========================================
- Coverage   40.66%   40.22%   -0.45%     
==========================================
  Files         199      199              
  Lines       25471    25763     +292     
  Branches     1278     1310      +32     
==========================================
+ Hits        10359    10363       +4     
- Misses      15067    15355     +288     
  Partials       45       45              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

const baselineEntry = stagedEntry ?? memberEntry;

return forkJoin({
current: this.fetchObjectVersion(item.object_ref),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this fetch use item.object_modified here? Without it, candidate diffs compare always against the latest object, which could potentially drift from the version pinned to the release track (e.g. if the member sync strategy doesn't track the latest object)

Comment on lines +772 to +775
const relationshipAddedAfter =
tier === 'candidate'
? this.findStagedEntry(item.object_ref)?.object_modified
: undefined;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should also check from the member entry when there isn't a staged entry, otherwise the candidate vs. member diffs won't mark relationships as added since the member version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants