Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
using: composite
steps:
- uses: pnpm/action-setup@v6.0.9
- uses: actions/setup-node@v6.4.0
- uses: actions/setup-node@v6.5.0
with:
node-version: 22
cache: pnpm
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ jobs:
typecheck-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6.0.3
- uses: actions/checkout@v6.1.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '--- .github/workflows/ci.yml ---\n'
cat -n .github/workflows/ci.yml | sed -n '1,220p'

printf '\n--- .github/workflows/docker.yml ---\n'
cat -n .github/workflows/docker.yml | sed -n '1,220p'

Repository: misskey-dev/sensitive-detector

Length of output: 259


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find every checkout usage in workflow files and show nearby context.
rg -n -C 3 'uses:\s*actions/checkout@' .github/workflows

Repository: misskey-dev/sensitive-detector

Length of output: 1372


🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- .github/workflows/ci.yml ---'
cat -n .github/workflows/ci.yml | sed -n '1,220p'

printf '\n%s\n' '--- .github/workflows/docker.yml ---'
cat -n .github/workflows/docker.yml | sed -n '1,220p'

printf '\n%s\n' '--- checkout usages ---'
rg -n -C 3 'uses:\s*actions/checkout@' .github/workflows

Repository: misskey-dev/sensitive-detector

Length of output: 6161


🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- .dockerignore ---'
if [ -f .dockerignore ]; then
  cat -n .dockerignore
else
  echo '(missing)'
fi

printf '\n%s\n' '--- .github/actions/setup ---'
if [ -d .github/actions/setup ]; then
  find .github/actions/setup -maxdepth 2 -type f | sort | while read -r f; do
    printf '\n[%s]\n' "$f"
    cat -n "$f"
  done
else
  echo '(missing)'
fi

Repository: misskey-dev/sensitive-detector

Length of output: 999


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect relevant ignore/config files only if present.
for f in .dockerignore .gitignore; do
  if [ -f "$f" ]; then
    printf '\n--- %s ---\n' "$f"
    cat -n "$f"
  fi
done

Repository: misskey-dev/sensitive-detector

Length of output: 6837


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Read only the small, relevant files around checkout-related workflow steps.
for f in .github/workflows/ci.yml .github/workflows/docker.yml .github/actions/setup/action.yml; do
  if [ -f "$f" ]; then
    printf '\n--- %s ---\n' "$f"
    cat -n "$f"
  fi
done

Repository: misskey-dev/sensitive-detector

Length of output: 5428


Disable checkout credential persistence in these workflows.
actions/checkout writes the token into .git/config; set persist-credentials: false unless a later git push/fetch is required.

  • .github/workflows/ci.yml#L13
  • .github/workflows/ci.yml#L21
  • .github/workflows/docker.yml#L35-L36
🧰 Tools
🪛 zizmor (1.26.1)

[warning] 13-13: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)

📍 Affects 2 files
  • .github/workflows/ci.yml#L13-L13 (this comment)
  • .github/workflows/ci.yml#L21-L21
  • .github/workflows/docker.yml#L35-L36
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 13, Disable checkout credential persistence
by setting persist-credentials to false on the actions/checkout steps at
.github/workflows/ci.yml lines 13 and 21, and .github/workflows/docker.yml lines
35-36; no later git push or fetch is required.

Source: Linters/SAST tools

- uses: ./.github/actions/setup
- run: pnpm typecheck
- run: pnpm lint

test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6.0.3
- uses: actions/checkout@v6.1.0
- uses: ./.github/actions/setup
- run: pnpm test
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
platform=${{ matrix.platform }}
echo "PLATFORM_PAIR=${platform//\//-}" >> $GITHUB_ENV
- name: Check out the repo
uses: actions/checkout@v6.0.2
uses: actions/checkout@v6.1.0
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v4
- name: Docker meta
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.0.2",
"private": true,
"type": "module",
"packageManager": "pnpm@11.8.0",
"packageManager": "pnpm@11.19.0",
"engines": {
"node": ">=22"
},
Expand Down
Loading