Repository navigation
Codacy: fix the browser error listener (rule crashed on it) - #3
Merged
Merged
Conversation
…d on an expression body) Validated with ESLint 8 + eslint-plugin-security-node, the rules Codacy runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
✅ No blocking issues noticed
No blocking findings were identified. No uncovered complex files or acceptance-criteria gaps were surfaced by the review agents.
Test suggestions
- Verify that a child-process error triggers the fallback console error message.
- Verify that synchronous spawn failures remain safely handled.
- Run the relevant lint/check command and confirm the error-listener rule completes successfully.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that a child-process error triggers the fallback console error message.
2. Verify that synchronous spawn failures remain safely handled.
3. Run the relevant lint/check command and confirm the error-listener rule completes successfully.
TIP Add a Jira or Linear ticket key to the branch or title so the reviewer can check the PR against it. Using another tracker? Tell us.
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2. Codacy still listed 9 runway findings after #2, all pointing at the old code. Running the same rules locally (ESLint 8 with
eslint-plugin-security-nodeand@typescript-eslint) showed why:detect-unhandled-event-errorscrashes on an error listener with an expression body (() => info(...)), which likely stopped Codacy re-checking the files.The listener now has a block body with
console.error(what the rule accepts). With it, all 7 flagged files lint clean; with inline comments ignored, exactly the 7 annotated async-error findings come back, so those suppressions are what clears them, and the other two are fixed in the code.npm run checkpasses.🤖 Generated with Claude Code