Repository navigation
Add whatbroke: explain failed CI runs on the PR - #1
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The workflow uses a mutable third-party action reference in a privileged context with permission to read logs and modify pull requests. This should be pinned to a verified full commit SHA before merging to prevent unreviewed upstream changes from executing with those permissions.
Test suggestions
- Verify a failed CI workflow_run invokes whatbroke with sufficient permissions to read logs and comment on the pull request.
- Verify successful CI runs do not invoke the explanatory job.
- Verify the workflow can process fork pull requests without checking out or executing repository code.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify a failed CI workflow_run invokes whatbroke with sufficient permissions to read logs and comment on the pull request.
2. Verify successful CI runs do not invoke the explanatory job.
3. Verify the workflow can process fork pull requests without checking out or executing repository code.
TIP Add a Jira or Linear ticket key to the branch or title so the reviewer can check the PR against it. Using another tracker? Tell us.
TIP How was this review? Give us feedback
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
✅ No blocking issues noticed
No blocking findings were identified in this review. The recommended workflow behavior remains unverified by automated tests, including trigger filtering, permissions and checkout independence, and log-diff ordering.
Test suggestions
- Verify the workflow triggers only for failed completions of the CI workflow.
- Verify the workflow invokes whatbroke with actions-read and pull-request-write permissions and no code checkout.
- Verify whatbroke reports only new log lines and orders failure output first.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the workflow triggers only for failed completions of the CI workflow.
2. Verify the workflow invokes whatbroke with actions-read and pull-request-write permissions and no code checkout.
3. Verify whatbroke reports only new log lines and orders failure output first.
TIP Add a Jira or Linear ticket key to the branch or title so the reviewer can check the PR against it. Using another tracker? Tell us.
TIP How was this review? Give us feedback
When the CI workflow fails, whatbroke comments on the pull request with only the log lines that weren't in the last passing run, failure first.
workflow_run), so it also works for PRs from forks and never checks out their code.actions: read(logs) andpull-requests: write(the comment).workflow_runworkflows only run from the default branch.🤖 Generated with Claude Code