Repository navigation
Codacy: stdout error listener reports with console.error - #20
Merged
Merged
Conversation
Validated with ESLint 8 + eslint-plugin-security-node, the rule Codacy runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
✅ No blocking issues noticed
No blocking findings were identified. The requested behavior appears to have no reported logic or security issues, though the error branches and lint compliance are not covered by automated tests.
About this PR
- Add automated regression tests for the quiet EPIPE path and the reported non-EPIPE path, including their exit statuses.
Test suggestions
- Verify that an EPIPE stdout error exits with status 0 without reporting an error.
- Verify that a non-EPIPE stdout error is reported with console.error and exits with status 1.
- Verify the updated listener passes the relevant lint check.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that an EPIPE stdout error exits with status 0 without reporting an error.
2. Verify that a non-EPIPE stdout error is reported with console.error and exits with status 1.
3. Verify the updated listener passes the relevant lint check.
TIP Add a Jira or Linear ticket key to the branch or title so the reviewer can check the PR against it. Using another tracker? Tell us.
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19. Running Codacy's rule locally (ESLint 8 +
eslint-plugin-security-node) showeddetect-unhandled-event-errorsstill fires onsrc/bin.ts: it only accepts error listeners that report withconsole.error(orreject). The listener now exits 0 on EPIPE and otherwise reports withconsole.errorand exits 1. Same behaviour, and it lints clean.The other remaining finding (
unbound-methodinsrc/report/terminal.ts) no longer fires on current main; Codacy's entry is stale and should clear on the next analysis.npm run checkpasses.🤖 Generated with Claude Code