Test switching to missing window#101
Merged
aik099 merged 1 commit intoJan 8, 2025
Merged
Conversation
Member
|
@uuf6429 , for me locally both selenium-based Mink drivers are passing this test. So I guess we can merge it. |
aik099
approved these changes
Jan 7, 2025
Member
Author
|
@aik099 thanks.. note that I only have read access to this repo - I can't approve/merge PRs nor select reviewers (just saying it to be clear that I can't merge this). |
Member
|
Merging. Thanks @uuf6429 . |
acoulton
pushed a commit
to ingenerator/chrome-mink-driver
that referenced
this pull request
Feb 15, 2025
[minkphp/driver-testsuite#101](minkphp/driver-testsuite#101) has introduced test coverage which expects an exception if we attempt to switch to a window which does not exist. chrome-mink-driver previously tried to handle this by dynamically creating popups with `window.open()`, but we will now throw a DriverException instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to minkphp/webdriver-classic-driver#10.
Failure is solved by #100.