fix(core): scope Bedrock principal admission to Bedrock - #138
Merged
minekube-ai-engineer[bot] merged 1 commit intoAug 9, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
Connect Java 0.15.x rejected ordinary Java sessions with
BedrockPrincipalAdmissionException: READINESSwhen generation-2 Bedrock principal mode wasrequire. This prevented Java players from joining newly configured endpoints.Root Cause
BedrockPrincipalConsumerenforced the presence of a signed Bedrock v2 envelope before checking the trusted session protocol. Java sessions correctly carry no Bedrock envelope, but were rejected as if they were Bedrock sessions.Fix
SESSION_PROTOCOL_BEDROCK.How to Verify
require.READINESS.Test Plan
./gradlew :core:test --tests 'com.minekube.connect.bedrock.BedrockPrincipalConsumerTest' --no-daemon./gradlew check --no-daemonRisk Assessment
Low — the bypass applies only when the trusted protocol is not Bedrock and no Bedrock v2 envelope exists. Bedrock require-mode behavior remains fail-closed.