Skip to content

Key release concurrency on the commit, not the branch #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navjottomer merged 1 commit into from
Aug 17, 2026
Merged

Key release concurrency on the commit, not the branch #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,15 @@ on:
push:
branches: [main]

# Keyed on the commit, not the branch. Every push to main used to share one group,
# and GitHub keeps only the newest *pending* run in a group — so merging several
# packages in quick succession cancelled the runs in between. Each of those runs was
# the only thing that would ever release its package, because detect works from that
# push's own github.event.before: the merge succeeded, the run showed "cancelled",
# and the package simply had no release until someone noticed. Per-commit means a run
# can never supersede another push's.
concurrency:
group: release-${{ github.ref }}
group: release-${{ github.sha }}
cancel-in-progress: false

permissions:
Expand Down Expand Up @@ -46,6 +53,13 @@ jobs:
timeout-minutes: 10
permissions:
contents: write
# The serialisation that is actually wanted: one leg at a time per package and
# version, so two pushes touching the same package cannot both get past the
# tag-exists check and race to create it. Waiting rather than cancelling, because
# the loser here still has work to do.
concurrency:
group: release-${{ matrix.package.slug }}-${{ matrix.package.version }}
cancel-in-progress: false
strategy:
fail-fast: false
matrix:
Expand Down