Repository navigation
Conversation
The action reviews the PR diff with reviewrules on the Anthropic API and posts each finding as a review comment on its line. The workflow runs it on block repos as a required workflow of an organization ruleset, when the PR has the ai-review label, so the block repos need no change.
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
The pin moves to the reviewrules commit that adds --session-dir (popoffvg/reviewrules#3).
A re-run on AVD PR 7 posted the same bug again because the model worded the question differently.
A block repo on v4-beta gets the review from the ai-review label alone, with no ruleset. The job checks that secrets.env holds ANTHROPIC_API_KEY, because a reusable workflow sees only the secrets its caller passes.
A repo with its own .reviewrules/ now gets the block rule set too. Its own rule_sets replace it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A block repo on
node-simple-pnpm.yaml@v4-betagets an AI review of its PR when the PR has theai-reviewlabel.node-simple-pnpm.yaml: a new jobai-reviewonpull_requestthat callsblock-review.yaml..github/workflows/block-review.yaml(reusable):secrets.envholdsANTHROPIC_API_KEY, and fails with an error that says where to add it;.reviewrules/config.json, writes the settings for the run: theblockrule set from block-review-rules atv0.1.0and the block ignore patterns. Nothing is committed.actions/review/reviewrules: installs reviewrules, reviews the diff (Haiku for the rules, Opus at medium effort for the bug hypotheses), and posts each finding as a review comment on its line. A finding outside the diff lines goes to the review body. A hidden marker stops a re-run from posting the same finding again. The artifactreviewrules-attempt-<n>holdsreport.jsonand the model sessions.Setup in a block repo
In
.github/workflows/build.yaml:node-simple-pnpm.yaml@v4-beta."ANTHROPIC_API_KEY": ${{ toJSON(secrets.ANTHROPIC_API_KEY) }}tosecrets.env. The org secret exists.Then add the
ai-reviewlabel to a PR.build.yamlstarts on opened, synchronize, and reopened, so the review runs on the next push, or when you re-run the "AI review" job.Needed before use
--session-dirflag). The action pins its commit81894bc; move the pin to the merge commit after a squash merge.milaboratory/block-review-rulesfor the fetch: make it public, or putREVIEWRULES_RULE_SETS_TOKENinsecrets.env.Tested
report.jsonand 33 session files.post-review.jswith a fake GitHub client: line placement, findings outside the diff, no repeat on a second run.actionlinton both workflows.ai-reviewjob insidenode-simple-pnpm.yaml. It calls@v4-betarefs, which hold the review action only after this PR merges.🤖 Generated with Claude Code