Repository navigation
node-simple-pnpm: publish without the stable channel when the merged PR is labelled mark-unstable - #225
Merged
Conversation
…PR is labelled mark-unstable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A block PR labelled
mark-unstablenow publishes the block without adding it to the stable channel. PRs without the label release as before.How it works
node-simple-pnpm.yaml, jobbuild-test-publish. A release takes two runs onmain, and each side is one check:GITHUB_SHA(GET /repos/{repo}/commits/{sha}/pulls). If it hasmark-unstable, the "Auto-generated changes" commit gets aPublish-Unstable: truetrailer.PL_PUBLISH_UNSTABLE=trueand adds a run notice.block-tools publishreads that variable as--unstable.The variable is set only when the trailer is present. block-tools reads
--unstablethrough commander, and commander treats any value as "on",falseincluded.Behaviour
block-tools publish. They do get one extra API call on runs that push a version commit.--unstableinprepublishOnly(mixcr-clonotyping and 4 others) stay unstable. The label can only make a release unstable, not stable.mark-unstablealready exists in 77 of the 78 block repos.import-bulk-count-matrixstill needs it, from someone with write access.Known gap
When two PRs merge close together, the first PR's version push is rejected and its run fails. The second PR's run then releases both, and only the second PR's label is checked. If that happens,
block-tools mark-stable --unmarkremoves the block from the stable channel.Before promoting to v4