Repository navigation
fix: converts wsl icon paths for windows toaster - #473
Merged
Merged
Conversation
mikaelbr
force-pushed
the
fix/wsl-icon-path-354
branch
from
October 9, 2026 19:53
45686a8 to
80df9fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under WSL,
WindowsToasterpassed theiconpath straight to SnoreToast as-p. A Linux path like/home/me/icon.pngisn't a local Windows file, so SnoreToast showed only "SnoreToast / New Notification" with no title or message.Changes (only under WSL, in
mapToWin8):/mnt/<letter>/...andfile:///mnt/<letter>/...are converted to<LETTER>:\...in plain JS (nowslpath, no shell).C:\...,file:///C:/...) are kept as before./mnt/cdrom/..., paths with.., URLs) drops the icon, so the text still shows.Also adds a short README note in the WSL section and a CHANGELOG entry.
Tested with new unit tests in
test/utils.js(mockingutils.isWSL), andpnpm testpasses. Not tested on real WSL.Fixes #354