Fix manager CT startup in local Docker setup#338
Open
ArshSSandhu wants to merge 1 commit into
Open
Conversation
runleveldev
requested changes
Jun 8, 2026
| # forcing a cores value can cause LXC to generate an invalid empty | ||
| # lxc.cgroup.cpuset.cpus line. Set MANAGER_CORES=4 to opt in. | ||
| MANAGER_CORES="${MANAGER_CORES:-}" | ||
| MANAGER_CORE_ARGS=() |
Collaborator
There was a problem hiding this comment.
We don't need to support "MANAGER_CORE_ARGS". I'm fine with no CPU pinning by default for manager.
|
|
||
| # Remove the temporary emergency entrypoint before the final start so the | ||
| # Manager CT boots to the default target with networking and services enabled. | ||
| pct set 100 --delete entrypoint || true |
Collaborator
There was a problem hiding this comment.
If the entrypoint fails to delete we need to assume the container is in a bad state and not start it. Let this fail rather than swallowing the error with || true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a local startup issue where the
proxmoxservice can become unhealthy because Manager CT100does not boot correctly in Docker Desktop + WSL2 environments.During debugging, Manager CT
100was created withcores: 4, which caused LXC to generate an invalid empty cpuset line:That prevented CT
100from starting. After removing thecoressetting, CT100could start, but it still had a temporary emergency boot entrypoint configured:This PR makes the core limit optional and removes the temporary emergency entrypoint before the final Manager CT startup.
Changes
MANAGER_CORES.--cores=4from the default local setup.Testing
Tested locally on Windows + Ubuntu WSL2 + Docker Desktop.
Started from a clean Docker state:
Verified the Proxmox healthcheck became healthy:
docker inspect opensource-server-proxmox-1 --format '{{.State.Health.Status}}'Result:
Also verified inside the Proxmox container:
Confirmed:
100is running.10.254.0.2.80/443.3000.curlreturnsHTTP/2 200.Notes
On the first startup, the healthcheck may briefly fail while Manager finishes booting, but it later becomes healthy once nginx is listening on
443.