Skip to content

fix(playwright): register payroll-settings listener before the settings click #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renemadsen merged 1 commit into from
Aug 28, 2026
Merged

fix(playwright): register payroll-settings listener before the settings click #1691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions eform-client/playwright/e2e/plugins/time-planning-pn/j/dashboard-edit-a.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,19 @@ test.describe('Dashboard edit values', () => {
const settingsGetPromise = page.waitForResponse(
r => r.url().includes('/api/time-planning-pn/settings') && r.request().method() === 'GET'
);
// Registered before the click alongside settingsGetPromise: getSettings() and
// getPayrollSettings() both fire synchronously from ngOnInit, so listening for
// this response only after settingsGetPromise resolves is too late — the
// payroll request has often already completed, leaving this promise unresolved
// until the 120s test timeout (no default action timeout is configured).
const payrollSettingsGetPromise = page.waitForResponse(
r => r.url().includes('/api/time-planning-pn/payroll/settings') && r.request().method() === 'GET'
);
await page.locator('#plugin-settings-link0').click();
await settingsGetPromise;

// Wait for payroll settings to finish loading (async call that causes re-render)
await page.waitForResponse(
r => r.url().includes('/api/time-planning-pn/payroll/settings') && r.request().method() === 'GET'
).catch(() => {});
await payrollSettingsGetPromise;
await page.waitForTimeout(500);

// Check autoBreakCalculationActiveToggle state and enable if needed
Expand Down
12 changes: 9 additions & 3 deletions eform-client/playwright/e2e/plugins/time-planning-pn/j1m/dashboard-edit-a.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,19 @@ test.describe('Dashboard edit values (j1m, flag-on, global values round-trip)',
const settingsGetPromise = page.waitForResponse(
r => r.url().includes('/api/time-planning-pn/settings') && r.request().method() === 'GET'
);
// Registered before the click alongside settingsGetPromise: getSettings() and
// getPayrollSettings() both fire synchronously from ngOnInit, so listening for
// this response only after settingsGetPromise resolves is too late — the
// payroll request has often already completed, leaving this promise unresolved
// until the 120s test timeout (no default action timeout is configured).
const payrollSettingsGetPromise = page.waitForResponse(
r => r.url().includes('/api/time-planning-pn/payroll/settings') && r.request().method() === 'GET'
);
await page.locator('#plugin-settings-link0').click();
await settingsGetPromise;

// Wait for payroll settings to finish loading (async call that causes re-render)
await page.waitForResponse(
r => r.url().includes('/api/time-planning-pn/payroll/settings') && r.request().method() === 'GET'
).catch(() => {});
await payrollSettingsGetPromise;
await page.waitForTimeout(500);

// Check autoBreakCalculationActiveToggle state and enable if needed
Expand Down
Loading