Cancel first in this plugin's dialogs

[renemadsen]

Ordering half of the button work. Depends on microting/eform-angular-frontend#8017, which decides the convention and teaches the shared gate to enforce it.

Reorders 13 dialog action rows so the dismissing button leads.

Why this was a separate decision

The audit deliberately left ordering open: 42 core dialogs and 48 plugin dialogs rendered [Save][Cancel] against 12 the other way, so cancel-first was the minority. It is also the one button inconsistency users actually feel — it moves the button under their cursor between one dialog and the next — so it warranted a decision rather than whichever way a sweep happened to run.

It is a pure move

Whole <button> elements swap position; nothing is retyped. Verified by diffing removed against added lines in this repo — the line multisets are identical, so no id, binding, tooltip, icon or translate pipe changed in transit. That check is the point: a re-typed button is how an id silently disappears and takes an e2e selector with it.

No touched row carries cdkFocusInitial, so no autofocus target moves.

🤖 Generated with Claude Code

https://claude.ai/code/session_015sXLtgzZU8QL9m84GqMkoJ

[Copilot]

Pull request overview

This PR standardizes dialog action ordering within the time-planning plugin by moving the dismissing action (Cancel/Close) to appear before the primary/destructive action across the affected modals, aligning with the “cancel first” convention referenced in the PR description.

Changes:

• Reordered action buttons in 13 Angular Material dialog templates so the dismissing action leads.
• Kept button contents/handlers/ids intact while swapping whole <button> elements to avoid selector regressions.
• Applied the same ordering across Working Hours, Registration Devices, Flexes, Break Policies, and Absence Requests dialogs.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
eform-client/src/app/plugins/modules/time-planning-pn/modules/working-hours/components/working-hours-actions/working-hours-upload-modal/working-hours-upload-modal.component.html	Moves “Close” before “Upload” in the upload modal actions.
eform-client/src/app/plugins/modules/time-planning-pn/modules/working-hours/components/working-hours-actions/working-hours-comment-office-update-modal/working-hours-comment-office-update-modal.component.html	Moves “Cancel” before “OK” in the comment office update modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/working-hours/components/working-hours-actions/working-hours-comment-office-all-update-modal/working-hours-comment-office-all-update-modal.component.html	Moves “Cancel” before “Save” in the comment office-all update modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/registration-devices/components/registration-devices-actions/registration-devices-otp-code/registration-devices-otp-code.component.html	Moves “Cancel” before “OK” in the OTP warning modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/registration-devices/components/registration-devices-actions/registration-devices-edit-modal/registration-devices-edit-modal.component.html	Moves “Cancel” before “Update” in the edit modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/registration-devices/components/registration-devices-actions/registration-devices-create-modal/registration-devices-create-modal.component.html	Moves “Cancel” before “Create” in the create modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/flexes/components/time-flexes-actions/comment-office-update-modal/time-flexes-comment-office-update-modal.component.html	Moves “Cancel” before “OK” in the flex comment office update modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/flexes/components/time-flexes-actions/comment-office-all-update-modal/time-flexes-comment-office-all-update-modal.component.html	Moves “Cancel” before “Save” in the flex comment office-all update modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/break-policies/components/break-policies-edit-modal/break-policies-edit-modal.component.html	Moves “Cancel” before “Save” in the break policy edit modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/break-policies/components/break-policies-delete-modal/break-policies-delete-modal.component.html	Moves “Cancel” before “Delete” in the break policy delete modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/break-policies/components/break-policies-create-modal/break-policies-create-modal.component.html	Moves “Cancel” before “Create” in the break policy create modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/absence-requests/components/absence-requests-actions/absence-requests-reject-modal/absence-requests-reject-modal.component.html	Moves “Cancel” before “Reject” in the absence reject modal.
eform-client/src/app/plugins/modules/time-planning-pn/modules/absence-requests/components/absence-requests-actions/absence-requests-approve-modal/absence-requests-approve-modal.component.html	Moves “Cancel” before “Approve” in the absence approve modal.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.