Repository navigation
perf(models): speed up removal of active provider connections - #398
Merged
Angnuo (angnuoli) merged 1 commit intoNov 18, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing a Qwen or MiniMax connection while it was selected as the default model fell back to the slower
config.applypath because removing its model references disqualified the lightweight write. Useconfig.setfor this removal as well, while still waiting for the saved configuration and runtime revision to agree before completing the MXC transaction.Changes
Type of Change
Testing
vitest run src/model-config-application.test.ts src/windows-node-mxc-model-config.test.tsvitest run src/utils/model-provider.test.ts src/views/SettingsView.models.test.tsgit diff --checkWarmed isolated measurements for removing the selected provider were 6.966s -> 3.619s and 6.025s -> 3.360s (
config.apply->config.set). Each round has one non-warmup sample per path. These measure configuration write and applied-revision confirmation, excluding outer MXC checks, production plugins, and UI latency.Checklist