Repository navigation
Gate MXC recovery guidance by sandbox mode - #397
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> # Conflicts: # desktop/src/config-write-service.ts # desktop/src/main.ts # desktop/src/model-config-application.test.ts # desktop/src/model-config-application.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mitigate common MXC filesystem failures through agent guidance and synchronize generated SOUL.md content with Full/Off mode. Preserve user-customized content and mode-independent command-consent, Windows transport, quoting, and memory guidance.
Related Issue
Relates to #379, #381, #394, and #395. Guidance mitigates these failures; it does not fix upstream metadata or host-loopback restrictions.
Changes
Type of Change
Testing
cd desktop && npm run test)cd desktop/renderer && npm run test)cd desktop && npm run build)Full test suites and production build were not run. Targeted commands run from
desktopon the merged PR head:npx --no-install vitest run src\windows-node-command-instructions.test.ts src\agent-personas.test.ts src\agent-workspaces-startup.test.ts src\agent-workspaces.test.ts src\windows-node-mxc-live-mode.test.ts src\windows-node-mxc-powershell-scope.test.ts src\windows-node-mxc-toggle.test.ts src\windows-node-mxc-modes.test.ts src\startup-order.test.ts src\config-write-service.test.ts src\model-config-application.test.ts- passed: 11 files, 255 tests; 2 existing pinned-runtime-dependent tests skipped. Existing Vite config-loader warning remains.npx --no-install tsc --noEmit- passed.npx --no-install eslint --quiet src\windows-node-command-instructions.ts src\windows-node-command-instructions.test.ts src\agent-personas.ts src\agent-personas.test.ts src\agent-workspaces-startup.test.ts src\windows-node-mxc-live-mode.test.ts src\windows-node-mxc-powershell-scope.test.ts src\main.ts- passed.npx --no-install prettier --check src\agent-personas.ts src\agent-personas.test.ts src\agent-workspaces-startup.test.ts src\main.ts src\windows-node-command-instructions.ts src\windows-node-command-instructions.test.ts src\windows-node-mxc-live-mode.test.ts src\windows-node-mxc-powershell-scope.test.ts- passed.git diff origin/main...HEAD --check- passed.Manual development validation before incorporating latest main:
npm run devcompiled and launched Electron; renderer and Gateway health returned HTTP 200; MXC reached active Full and application-service-ready. The user successfully cloned a repository, then switched MXC Off. The active main SOUL.md was updated at the switch and no longer contained generated MXC sections or declare-access instructions, while command consent remained ask-when-needed. This is a user-task success, not proof all tool calls were contained.Harbor reruns of the seven previously failing cases are in preparation using the normal product toolset rather than artificial exec-only restrictions. Results are not yet claimed. Harbor code remains in its separate repository and is not included in this PR.
Checklist