Repository navigation
Fix unlimited timeout handling in Windows Node - #396
Merged
yikkuro (yikkuro) merged 2 commits intoNov 18, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Windows Node execution when OpenClaw sends
timeoutMs: nullfor an explicitly unlimited command timeout. Previously this caused an exception instead of running the command.Related Issue
N/A
Changes
nulland zero as no execution deadline; preserve the default for an omitted timeout, clamp positive values and reject malformed values.Type of Change
Testing
cd desktop && npm run test)cd desktop/renderer && npm run test)cd desktop && npm run build)dotnet test windows-node-host.Tests/MicroClaw.WindowsNodeHost.Tests.csproj -c Release --no-restore -p:ImportDirectoryBuildProps=false -p:ImportDirectoryBuildTargets=false -p:UseSharedCompilation=false -m:1 --verbosity quiet: passed (224 passed, 10 skipped, 0 failed; native test is opt-in and skipped in this run).MICROCLAW_MXC_NATIVE_TEST_SCRATCHset to an isolated session directory,dotnet test windows-node-host.Tests/MicroClaw.WindowsNodeHost.Tests.csproj -c Release --no-restore -p:ImportDirectoryBuildProps=false -p:ImportDirectoryBuildTargets=false -p:UseSharedCompilation=false -m:1 --filter FullyQualifiedName~NativeNoTimeoutCommandCompletesAndCancellationSettlesProcess --verbosity quiet: passed (1 native MXC test, 0 skipped, 0 failed). It verifies that a contained no-timeout command completes beyond the configured deadline and that caller cancellation settles a second process.dotnet build windows-node-host/MicroClaw.WindowsNodeHost.csproj -c Release --no-restore -p:ImportDirectoryBuildProps=false -p:ImportDirectoryBuildTargets=false -p:UseSharedCompilation=false -m:1 --verbosity quiet: passed (0 errors, before the test-only follow-up).MxcSdkNativeTests.cs.Checklist