Repository navigation
fix: include one-byte final upload slices - #2164
Open
Vinay Kumar (Vcode2407) wants to merge 1 commit into
Open
Vinay Kumar (Vcode2407) wants to merge 1 commit into
Vinay Kumar (Vcode2407) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
A file that is exactly one byte larger than a multiple of the slice size can get stuck with its final byte unuploaded. The slice planner uses inclusive offsets, so this change schedules a one-byte slice when its start and end offsets are equal.
The regression test uses a 320 KiB slice size and a file one byte larger. It verifies that the second slice covers exactly the final byte.
Fixes microsoftgraph/msgraph-sdk-java#2581
Validation
Ran
mvn verifywith JDK 21. All 80 tests passed, including the new regression test, and SpotBugs reported no findings.