Skip to content

feat: Add automatic perf runtime selection - #1308

Merged
xieofxie merged 2 commits into
mainfrom
hualxie/perf_auto_runtime
Aug 14, 2026
Merged

feat: Add automatic perf runtime selection#1308
xieofxie merged 2 commits into
mainfrom
hualxie/perf_auto_runtime

Conversation

@xieofxie

Copy link
Copy Markdown
Contributor

Summary

  • add auto as the default perf --runtime choice
  • select winml-genai for model folders containing genai_config.json
  • fall back to winml for all other model inputs while preserving explicit runtime choices
  • cover automatic selection and CLI dispatch behavior with unit tests

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@xieofxie
xieofxie requested a review from a team as a code owner August 13, 2026 06:42
@xieofxie xieofxie changed the title Add automatic perf runtime selection feat: Add automatic perf runtime selection Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto runtime selection works for ordinary paths, but normalized local paths are not propagated to the GenAI dispatch path, causing valid bundle inputs such as ~/bundle to be misrouted after detection.

Comment thread src/winml/modelkit/commands/perf.py
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the latest changes. The normalized model path is now propagated directly to the GenAI runtime, resolving the prior dispatch mismatch for paths such as ~/bundle. Explicit runtime choices and model-ID auto-build behavior remain intact, and no new blocking issues were found.

@xieofxie
xieofxie merged commit 19e9ba8 into main Aug 14, 2026
9 checks passed
@xieofxie
xieofxie deleted the hualxie/perf_auto_runtime branch August 14, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants